fix(await-async-util): false positives due to empty strings (#733)

testing-library · Feb 15, 2023 · c2b8515 · c2b8515
1 parent 34a0a55
commit c2b8515
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 2 deletions.
diff --git a/lib/rules/await-async-utils.ts b/lib/rules/await-async-utils.ts
@@ -44,10 +44,16 @@ export default createTestingLibraryRule<Options, MessageIds>({
 
 		function detectAsyncUtilWrapper(node: TSESTree.Identifier) {
 			const innerFunction = getInnermostReturningFunction(context, node);
+			if (!innerFunction) {
+				return;
+			}
 
-			if (innerFunction) {
-				functionWrappersNames.push(getFunctionName(innerFunction));
+			const functionName = getFunctionName(innerFunction);
+			if (functionName.length === 0) {
+				return;
 			}
+
+			functionWrappersNames.push(functionName);
 		}
 
 		/*

diff --git a/tests/lib/rules/await-async-utils.test.ts b/tests/lib/rules/await-async-utils.test.ts
@@ -292,6 +292,38 @@ ruleTester.run(RULE_NAME, rule, {
 
           await setup().waitForAsyncUtil();
         });
+      `,
+		})),
+		...ASYNC_UTILS.map((asyncUtil) => ({
+			code: `
+          import React from 'react';
+          import { render, act } from '@testing-library/react';
+          
+          const doWithAct = async (timeout) => {
+            await act(async () => await ${asyncUtil}(screen.getByTestId('my-test')));
+          };
+          
+          describe('Component', () => {
+            const mock = jest.fn();
+          
+            it('test', async () => {
+              let Component = () => {
+                mock(1);
+                return <div />;
+              };
+              render(<Component />);
+          
+              await doWithAct(500);
+          
+              const myNumberTestVar = 1;
+              const myBooleanTestVar = false;
+              const myArrayTestVar = [1, 2];
+              const myStringTestVar = 'hello world';
+              const myObjectTestVar = { hello: 'world' };
+
+              expect(mock).toHaveBeenCalledWith(myNumberTestVar);
+            });
+          });
       `,
 		})),
 	]),