fix(await-async-events): false positives for userEvent.setup() return…

…ed (#895)
testing-library · Apr 15, 2024 · fb32c5c · fb32c5c
1 parent 767f1be
commit fb32c5c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/lib/rules/await-async-events.ts b/lib/rules/await-async-events.ts
@@ -122,6 +122,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
 					(isFireEventEnabled && helpers.isFireEventMethod(node)) ||
 					(isUserEventEnabled && helpers.isUserEventMethod(node))
 				) {
+					if (node.name === USER_EVENT_SETUP_FUNCTION_NAME) {
+						return;
+					}
+
 					detectEventMethodWrapper(node);
 
 					const closestCallExpression = findClosestCallExpressionNode(
@@ -133,10 +137,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
 						return;
 					}
 
-					if (node.name === USER_EVENT_SETUP_FUNCTION_NAME) {
-						return;
-					}
-
 					const references = getVariableReferences(
 						context,
 						closestCallExpression.parent

diff --git a/tests/lib/rules/await-async-events.test.ts b/tests/lib/rules/await-async-events.test.ts
@@ -204,6 +204,16 @@ ruleTester.run(RULE_NAME, rule, {
 				`,
 				options: [{ eventModule: 'userEvent' }] as const,
 			},
+			{
+				code: `
+				import userEvent from '${testingFramework}'
+				const customSetup = () => userEvent.setup();
+				test('setup method called and returned as arrow function body is valid', () => {
+					const user = customSetup();
+				})
+				`,
+				options: [{ eventModule: 'userEvent' }] as const,
+			},
 			{
 				code: `
 				import userEvent from '${testingFramework}'