fix(prefer-presence-queries): ignore getBy* inside within for on absence queries
#740
Conversation
|
Hey @Belco90 - thoughts on this PR? Would love to get it in to clean up this issue. |
|
@nathanmmiller Sorry, I'm not available yet. I hope I can check this by the end of the month. |
|
@nathanmmiller thanks for your patience! I'm slowly catching up, so I hope I can review it soon. |
|
Hey @nathanmmiller! It's been a while since you created this PR. Are you still willing to contribute? |
|
Yes sorry for the delay. The remaining ask is just to add documentation,
right?
…On Tue, Aug 1, 2023 at 12:24 PM Mario Beltrán ***@***.***> wrote:
Hey @nathanmmiller <https://github.com/nathanmmiller>! It's been a while
since you created this PR. Are you still willing to contribute?
—
Reply to this email directly, view it on GitHub
<#740 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI6QW34TN3BCDHZJHHYCPBLXTEUVPANCNFSM6AAAAAAV7WEP3E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
|
@nathanmmiller yes, only doc changes and it's ready to go. |
Docs added! |
Belco90
changed the title
getBy* inside within for on absence queries
|
@all-contributors please add @nathanmmiller for code and test |
|
I've put up a pull request to add @nathanmmiller! 🎉 |
|
🎉 This PR is included in version 5.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…ence queries
Checks
Changes
Context
Fixes #518 [Well, partially fixes it.]