Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure merge queues #867

Merged
merged 4 commits into from Jan 12, 2024
Merged

chore: configure merge queues #867

merged 4 commits into from Jan 12, 2024

Conversation

Belco90
Copy link
Member

@Belco90 Belco90 commented Jan 12, 2024

Checks

Changes

  • Splitting the current pipeline workflow in 3: verifications, ci, and release
  • Enabling merge queues

Context

The idea behind this change is to:

  • make sure that branches are up-to-date before merging without forcing users to keep the branch updated with the last main changes
  • allow queuing several PRs without waiting for others to get merged
  • flag all verification jobs as required for merging a PR without enabling them through the required checks setting. Using this setting is really painful because every time a job name is changed, we need to update the settings. For example, when we update the Node or ESLint versions supported, we need to go there and update the job names expected. With this new mechanism (ci workflow running verifications workflow and forcing all jobs to be successful) we dynamically make all verification jobs required for both PRs and merge queues.

@Belco90 Belco90 added the chore Changes that affect the build system, CI config or other changes that don't modify src/test files label Jan 12, 2024
@Belco90 Belco90 self-assigned this Jan 12, 2024
@Belco90 Belco90 added this pull request to the merge queue Jan 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 12, 2024
@Belco90 Belco90 added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit c74b006 Jan 12, 2024
29 checks passed
@Belco90 Belco90 deleted the configure-merge-queues branch January 12, 2024 12:20
@Belco90
Copy link
Member Author

Belco90 commented Jan 12, 2024

@all-contributors please add @Belco90 for infra and maintenance

Copy link
Contributor

@Belco90

I've put up a pull request to add @Belco90! 🎉

Copy link

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test files released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant