Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix ts-expect-error #873

Merged
merged 2 commits into from Jan 15, 2024
Merged

refactor: fix ts-expect-error #873

merged 2 commits into from Jan 15, 2024

Conversation

Belco90
Copy link
Member

@Belco90 Belco90 commented Jan 14, 2024

Checks

Changes

  • Fix TS errors silenced with @ts-expect-error

Context

These errors were silenced in #858

@Belco90 Belco90 added the chore Changes that affect the build system, CI config or other changes that don't modify src/test files label Jan 14, 2024
@Belco90 Belco90 self-assigned this Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (93a6ab9) 96.23% compared to head (d53fe8f) 96.20%.

Files Patch % Lines
lib/rules/no-await-sync-events.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   96.23%   96.20%   -0.04%     
==========================================
  Files          44       44              
  Lines        2419     2422       +3     
  Branches     1000     1003       +3     
==========================================
+ Hits         2328     2330       +2     
- Misses         91       92       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Belco90 Belco90 requested a review from a team January 14, 2024 13:42
@Belco90
Copy link
Member Author

Belco90 commented Jan 14, 2024

cc @lesha1201

@Belco90 Belco90 merged commit 5497dc2 into main Jan 15, 2024
31 of 33 checks passed
@Belco90 Belco90 deleted the fix-ts-expect-errors branch January 15, 2024 07:42
Copy link

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test files released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant