Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable max-lines-per-function for tests files #198

Merged
merged 5 commits into from Jun 17, 2020
Merged

Disable max-lines-per-function for tests files #198

merged 5 commits into from Jun 17, 2020

Conversation

lourenci
Copy link
Contributor

As discussed in #196 (comment).

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #198   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          315       315           
  Branches        71        71           
=========================================
  Hits           315       315           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e39222...be81588. Read the comment docs.

@lourenci
Copy link
Contributor Author

Hi, @gnapse. Do you have any plans to merge this? Feel free to close the PR if you want.

Thanks.

@gnapse gnapse merged commit 2449b44 into testing-library:master Jun 17, 2020
@lourenci lourenci deleted the disable-max-lines-per-function-tests branch June 17, 2020 11:44
@gnapse
Copy link
Member

gnapse commented Jun 25, 2020

🎉 This PR is included in version 5.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants