Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get supported roles for toBeChecked via aria-query #267

Merged
merged 2 commits into from Jun 25, 2020
Merged

Get supported roles for toBeChecked via aria-query #267

merged 2 commits into from Jun 25, 2020

Commits on Jun 25, 2020

  1. Add toSentence utils function 

    Helper to join arrays of strings into natural language enumerations
separating the last two items with a coordinating conjunction like
"and" or "or".
    @tf
    tf committed Jun 25, 2020
    Copy the full SHA
    eee32a9 View commit details
    Browse the repository at this point in the history

  2. Get supported roles for toBeChecked via aria-query 

    Instead of hard coding a list of roles, use information provided by
the `aria-query` package to determine whether an element with a given
role supports the `aria-checked` attribute.

Dynamically generate an error message listing all supported
roles. Make error message expectations more fuzzy to prevent test
failures if the list of supported roles should ever change.
    @tf
    tf committed Jun 25, 2020
    Copy the full SHA
    e9e6f1c View commit details
    Browse the repository at this point in the history