Suggest using toBeEmptyDOMElement instead of toBeEmpty #284
Conversation
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 315 315
Branches 72 72
=========================================
Hits 315 315
Continue to review full report at Codecov.
|
| @@ -83,7 +83,7 @@ describe('.toHaveTextContent', () => { | |||
| ) | |||
| }) | |||
|
|
|||
| test('when matching with empty string and element with content suggest using toBeEmpty instead', () => { | |||
| test('when matching with empty string and element with content, suggest using toBeEmptyDOMElement instead', () => { | |||
There was a problem hiding this comment.
I wonder why the toThrowError line below did not have to be changed as well. Shouldn't the expected error message change to /toBeEmptyDOMElement()/?
I think it's because there's a mistake in that regular expression. Those parenthesis are not being matched but they are interpreted as an empty group. Can you please change that regexp to be /toBeEmptyDOMElement\(\)/?
There was a problem hiding this comment.
Nice catch. It slipped past me.
I just changed it. Thanks!
|
🎉 This PR is included in version 5.11.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Suggest using toBeEmptyDOMElement instead of toBeEmpty.
Why:
Since PR #254 we are deprecating toBeEmpty in favour of toBeEmptyDOMElement, so we should suggest using it instead.
How:
When checking with an empty string using toHaveTextContent, the following error message is displayed:
In this PR I changed it to:
Checklist: