Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-dom): Update deprecated messaging for toHaveDescription to p… #390

Conversation

christemple
Copy link

@christemple christemple commented Jul 27, 2021

What:

Update deprecated messaging for toHaveDescription to provide advice on using toHaveAccessibleDescription instead

Why:

The deprecation message for toHaveDescription was wrong, I assume because of a copy/paste mishap.
This updates it to be more helpful in migrating away from the deprecated function.

How:

By modifying the deprecated messaging for toHaveDescription.

Checklist:

  • Documentation
  • Tests
  • Updated Type Definitions
  • Ready to be merged

…rovide advice on using toHaveAccessibleDescription instead
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #390 (5cc70cf) into main (d24b6be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          615       615           
  Branches       223       225    +2     
=========================================
  Hits           615       615           
Impacted Files Coverage Δ
src/to-have-description.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24b6be...5cc70cf. Read the comment docs.

@christemple
Copy link
Author

No point fixing the conflicts since another PR has been raised and merged since: #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants