feat(toHaveValue): Asserting aria-valuenow #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynevanson
suggested changes
Sep 21, 2022
src/utils.js
Outdated
| return element.value | ||
| default: { | ||
| const accessibleValue = getAccessibleValue(element) | ||
| return element.value ?? accessibleValue |
There was a problem hiding this comment.
@idanen Which should have precedence, value or aria-valuenow? At the moment it looks like the former has precedence.
There was a problem hiding this comment.
value should take precedence.
That's how Chrome's accessibility tab behaves
Co-authored-by: Wayne Van Son <waynevanson@gmail.com>
waynevanson
approved these changes
Sep 22, 2022
|
@gnapse @nickmccurdy any chance one of you can help push this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #478
What:
Change
.toHaveValue()to supportaria-valuenowWhy:
How:
Checklist: