refactor: expose legacy extend-expect #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 14 +1
Lines 252 253 +1
Branches 77 77
=========================================
+ Hits 252 253 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mdjastrzebski
force-pushed
the
chore/expose-legacy-exports
branch
from
b816e50
to
7f3c4a2
Compare
mdjastrzebski
changed the title
|
🎉 This PR is included in version 5.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR is exposing alternative
legacy_toXxxmatcher naming, in order to support ongoing migration of Jest Native matchers to RNTL, so that users can use both new RNTL matchers and legacy Jest Native matchers to gradually migrate their code.This PR is not doing advertising this change yet, as the RNTL migration is ongoing. I would add relevant documentation when RNTL matchers are read.
Why:
This is needed as migrated matchers are usually named the same as Jest Native matchers, so without this there would be a naming clash.
How:
Add
legacy-extend-expectexport, so which extendsexpectwithlegacy_toXxxmatchers rather than typicallytoXxxnaming. The originalextend-expectremains still available, so existing users should not be affected.Checklist: