Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "only" qualifier from asyncHook test case #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Sep 28, 2020

Mistakenly left in #9

All tests still pass.

The wait deprecation message now logs directly to the terminal output in the course of running the tests. While not ideal, this appears to be the same behavior as in running npm test in react-hooks-testing-library, and doesn't otherwise cause the tests to fail. A better approach may be to suppress console logging (example).

Before:

Test Suites: 1 skipped, 13 passed, 13 of 14 total
Tests:       30 skipped, 35 passed, 65 total

After:

Test Suites: 1 skipped, 13 passed, 13 of 14 total
Tests:       8 skipped, 57 passed, 65 total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant