Skip to content

Commit

Permalink
fix(types) Correct overload order for act without strictNullChecks (#622
Browse files Browse the repository at this point in the history
)
  • Loading branch information
andyrooger committed May 18, 2021
1 parent 18f7913 commit 09a96d1
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,15 @@
"contributions": [
"maintenance"
]
},
{
"login": "andyrooger",
"name": "andyrooger",
"avatar_url": "https://avatars.githubusercontent.com/u/420834?v=4",
"profile": "https://github.com/andyrooger",
"contributions": [
"code"
]
}
],
"skipCi": true,
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
</tr>
<tr>
<td align="center"><a href="https://matan.io"><img src="https://avatars.githubusercontent.com/u/12711091?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Matan Borenkraout</b></sub></a><br /><a href="#maintenance-MatanBobi" title="Maintenance">🚧</a></td>
<td align="center"><a href="https://github.com/andyrooger"><img src="https://avatars.githubusercontent.com/u/420834?v=4?s=100" width="100px;" alt=""/><br /><sub><b>andyrooger</b></sub></a><br /><a href="https://github.com/testing-library/react-hooks-testing-library/commits?author=andyrooger" title="Code">💻</a></td>
</tr>
</table>

Expand Down
2 changes: 1 addition & 1 deletion src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ export type RenderHookOptions<TProps> = {
}

export type Act = {
(callback: () => void | undefined): void
(callback: () => Promise<void | undefined>): Promise<undefined>
(callback: () => void | undefined): void
}

export type CleanupCallback = () => Promise<void> | void

0 comments on commit 09a96d1

Please sign in to comment.