fix: fixed potential error when hook suspends and error is accessed

testing-library · Jan 24, 2021 · 1a0c4d3 · 1a0c4d3
1 parent 3b45b4d
commit 1a0c4d3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src/core/index.ts b/src/core/index.ts
@@ -19,7 +19,7 @@ function resultContainer<TValue>() {
       return value as TValue
     },
     get error() {
-      const { error } = results[results.length - 1]
+      const { error } = results[results.length - 1] ?? {}
       return error
     }
   }

diff --git a/src/dom/__tests__/suspenseHook.test.ts b/src/dom/__tests__/suspenseHook.test.ts
@@ -52,4 +52,10 @@ describe('suspense hook tests', () => {
 
     expect(result.current).toBe(undefined)
   })
+
+  test('should return undefined if error is requested before suspension has resolved', async () => {
+    const { result } = renderHook(() => useFetchName(true))
+
+    expect(result.error).toBe(undefined)
+  })
 })
diff --git a/src/native/__tests__/suspenseHook.test.ts b/src/native/__tests__/suspenseHook.test.ts
@@ -52,4 +52,10 @@ describe('suspense hook tests', () => {
 
     expect(result.current).toBe(undefined)
   })
+
+  test('should return undefined if error is requested before suspension has resolved', async () => {
+    const { result } = renderHook(() => useFetchName(true))
+
+    expect(result.error).toBe(undefined)
+  })
 })