fix(types): changed callback signature on waitFor to match old types

testing-library · Dec 23, 2020 · 1ea2afe · 1ea2afe
1 parent 5471a34
commit 1ea2afe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -8,7 +8,8 @@
     "import/no-unresolved": "off",
     "react-hooks/rules-of-hooks": "off",
     "@typescript-eslint/no-floating-promises": "off",
-    "@typescript-eslint/no-unnecessary-condition": "off"
+    "@typescript-eslint/no-unnecessary-condition": "off",
+    "@typescript-eslint/no-invalid-void-type": "off"
   },
   "parserOptions": {
     "project": ["./tsconfig.json", "./test/tsconfig.json"]

diff --git a/src/asyncUtils.ts b/src/asyncUtils.ts
@@ -42,14 +42,14 @@ function asyncUtils(addResolver: (callback: () => void) => void) {
     await nextUpdatePromise
   }
 
-  const waitFor = async <T>(
-    callback: () => T | Promise<T>,
+  const waitFor = async (
+    callback: () => boolean | void,
     { interval, timeout, suppressErrors = true }: WaitOptions = {}
   ) => {
     const checkResult = () => {
       try {
         const callbackResult = callback()
-        return callbackResult || callbackResult === undefined
+        return callbackResult ?? callbackResult === undefined
       } catch (error: unknown) {
         if (!suppressErrors) {
           throw error as Error