fix: stop appending container elements to document body

testing-library · Jan 12, 2021 · bab38d9 · bab38d9
1 parent 4f2dd80
commit bab38d9
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/src/dom/pure.ts b/src/dom/pure.ts
@@ -11,12 +11,10 @@ function createDomRenderer<TProps, TResult>(
   { wrapper }: RendererOptions<TProps>
 ) {
   const container = document.createElement('div')
-
   const testHarness = createTestHarness(rendererProps, wrapper)
 
   return {
     render(props?: TProps) {
-      document.body.appendChild(container)
       act(() => {
         ReactDOM.render(testHarness(props), container)
       })
@@ -30,7 +28,6 @@ function createDomRenderer<TProps, TResult>(
       act(() => {
         ReactDOM.unmountComponentAtNode(container)
       })
-      document.body.removeChild(container)
     },
     act
   }

diff --git a/src/native/pure.ts b/src/native/pure.ts
@@ -10,7 +10,6 @@ function createNativeRenderer<TProps, TResult>(
   { wrapper }: RendererOptions<TProps>
 ) {
   let container: ReactTestRenderer
-
   const testHarness = createTestHarness(rendererProps, wrapper)
 
   return {

diff --git a/src/server/pure.ts b/src/server/pure.ts
@@ -11,12 +11,10 @@ function createServerRenderer<TProps, TResult>(
   rendererProps: RendererProps<TProps, TResult>,
   { wrapper }: RendererOptions<TProps>
 ) {
-  const container = document.createElement('div')
-
-  const testHarness = createTestHarness(rendererProps, wrapper, false)
-
   let renderProps: TProps | undefined
   let hydrated = false
+  const container = document.createElement('div')
+  const testHarness = createTestHarness(rendererProps, wrapper, false)
 
   return {
     render(props?: TProps) {
@@ -30,7 +28,6 @@ function createServerRenderer<TProps, TResult>(
       if (hydrated) {
         throw new Error('The component can only be hydrated once')
       } else {
-        document.body.appendChild(container)
         act(() => {
           ReactDOM.hydrate(testHarness(renderProps), container)
         })
@@ -49,7 +46,6 @@ function createServerRenderer<TProps, TResult>(
       if (hydrated) {
         act(() => {
           ReactDOM.unmountComponentAtNode(container)
-          document.body.removeChild(container)
         })
       }
     },