fix: Stop restricting container option based on hydrate
#1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f5f9f9e:
|
eps1lon
force-pushed
the
simple-container
branch
from
0538bff
to
cf10c6b
Compare
eps1lon
force-pushed
the
simple-container
branch
from
cf10c6b
to
f5f9f9e
Compare
eps1lon
commented
Apr 24, 2024
| @@ -1,4 +1,7 @@ | |||
| { | |||
| "extends": "../node_modules/kcd-scripts/shared-tsconfig.json", | |||
| "compilerOptions": { | |||
| "skipLibCheck": false | |||
There was a problem hiding this comment.
We never actually typechecked the .d.ts files before.
MatanBobi
reviewed
Apr 25, 2024
| @@ -179,19 +171,15 @@ export interface RenderHookResult<Result, Props> { | |||
| unmount: () => void | |||
| } | |||
|
|
|||
| export interface BaseRenderHookOptions< | |||
| /** @deprecated */ | |||
| export type BaseRenderHookOptions< | |||
There was a problem hiding this comment.
Just so I'll understand, what's the motivation with changing this one from an interface to a type?
There was a problem hiding this comment.
it's just an alias for RenderHookOptions whereas an interface would create a new type.
MatanBobi
approved these changes
Apr 25, 2024
eps1lon
changed the title
container option based on hydratecontainer option based on hydrate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1312
Closes #1311
It's really not worth it to have such extensive types just to restrict
containerproperly. Especially because it makes composingrenderandrenderHookso hard. And we do want to encourage wrappingrenderin your tests.