docs: Document known issue with React 16.8 #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandroperea
previously approved these changes
Aug 5, 2019
These warnings will be common among users with React 16.8. By adding this to the README we can address a common concern until React 16.9 becomes common.
JSFernandes
force-pushed
the
pr/document-react-16-8
branch
from
583a753
to
26e65b0
Compare
alejandroperea
previously approved these changes
Aug 5, 2019
kentcdodds
dismissed stale reviews from alejandroperea and themself
via
a9cf184
kentcdodds
approved these changes
Aug 5, 2019
|
@all-contributors please add @JSFernandes for docs |
|
I've put up a pull request to add @JSFernandes! 🎉 |
|
@all-contributors please add @alejandroperea for review |
|
I've put up a pull request to add @alejandroperea! 🎉 |
|
🎉 This PR is included in version 8.0.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: This PR documents the issue discussed in #281 and how to circumvent it
Why: As of right now, React DOM 16.9 has not been released. Thus, it can be useful to have a notice about the warnings in the README. We may remove these changes some weeks after React 16.9 is released.
Checklist: