Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Node 8 support #576

Merged
merged 3 commits into from Mar 4, 2020
Merged

Drop Node 8 support #576

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2caf840
update node to version 10 as 8 is no longer LTS
thomasgrz Jan 23, 2020
c87c782
updating travis yml file with newer versions of node
thomasgrz Jan 23, 2020
5110fde
Merge branch 'beta' into pr/update-node-engine
Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Expand Up @@ -6,9 +6,9 @@ cache:
notifications:
email: false
node_js:
- '8'
- '10'
- '12'
- '13'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node.js folks don't recommend v13 for production since it wont be promoted to LTS. Maybe both just v10 and v12 will suffice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the testing environment not the production environment. If this adds too much work we can remove it. Otherwise it seems useful to monitor support.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make it node, so it's just the latest version of Node.js

install:
- npm install
# as requested by the React team :)
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
"main": "dist/index.js",
"module": "dist/@testing-library/react.esm.js",
"engines": {
"node": ">=8"
"node": ">=10"
},
"scripts": {
"prebuild": "rimraf dist",
Expand Down Expand Up @@ -85,4 +85,4 @@
"url": "https://github.com/testing-library/react-testing-library/issues"
},
"homepage": "https://github.com/testing-library/react-testing-library#readme"
}
}