Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade all dependencies (and fix UMD build) #653

Merged
merged 1 commit into from Apr 30, 2020
Merged

Conversation

kentcdodds
Copy link
Member

What: Update all deps and use dotenv-cli to set environment variables for the build

Why:

UMD Build output before:

[build] [umd] (!) Missing global variable name
[build] [umd] Use output.globals to specify browser global variable names corresponding to external modules
[build] [umd] react-dom/test-utils (guessing 'testUtils')

We no longer get that warning with these changes

How:

Using dotenv-cli to set environment variables based on .bundle.main.env and .bundle.pure.env which are used within kcd-scripts to configure rollup. Was way easier than setting them with cross-env like we were doing before.

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 04d263b:

Sandbox Source
keen-hoover-jvwtc Configuration
immutable-http-qglg6 Configuration

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 88e12cc:

Sandbox Source
blazing-pond-ppq7f Configuration
goofy-forest-sp0tv Configuration

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 65cc476:

Sandbox Source
epic-bogdan-w270p Configuration
gifted-dream-zuho4 Configuration

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #653 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #653   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          103       103           
  Branches        15        15           
=========================================
  Hits           103       103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6446739...65cc476. Read the comment docs.

@kentcdodds kentcdodds merged commit a75fa35 into master Apr 30, 2020
@kentcdodds kentcdodds deleted the update-fix-umd branch April 30, 2020 16:08
@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 10.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant