Fix pretty format import #705
Conversation
Typings use `import {OptionsReceived as PrettyFormatOptions} from 'pretty-format'`
Fix #694
Unfortunately as a side-effect of housing typings in this repo, we need to explicitly add `pretty-format` as a dependency since our types rely on it. Note this project source code itself does not explicitly need `pretty-format` but instead just its typings.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 073e99c:
|
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 100 100
Branches 16 16
=========================================
Hits 100 100 Continue to review full report at Codecov.
|
This was my worry too, and maybe this issue is not for all users. I'll keep investigating with the OP repo. |
|
I'm going to close this PR, I have given feedback to the OP. |
|
Seems like we do need this based on #694 (comment) |
What: add
pretty-formatas a dependencyWhy: fix #694, since moving typings to this repo we have to make
pretty-formatan explicit dependency since our types rely on itHow: update
package.jsonChecklist:
docs site N/A
I tried with
devDependencybut those packages will not be installed on consumer projects, https://stackoverflow.com/questions/45176661/how-do-i-decide-whether-types-goes-into-dependencies-or-devdependencies is a good discussion that helped me wrap my head around what is necessary.