docs: add docs about defaultIgnore config #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
timdeschryver
approved these changes
Jun 16, 2022
eps1lon
approved these changes
Jun 16, 2022
eps1lon
requested changes
Jun 16, 2022
| ### `defaultIgnore` | ||
|
|
||
| The default value for the [`ignore` option](queries/bytext.mdx#ignore) used by | ||
| [`getByText`](queries/bytext.mdx). Defaults to `script, style`. |
There was a problem hiding this comment.
Now that I think about it: It's not just *ByText.This also affects the nodes we print in error messages.
There was a problem hiding this comment.
@eps1lon do you have a specific wording you'd like me to put here? 👀
There was a problem hiding this comment.
@eps1lon I gave it a shot. 😅 What do you think?
robin-drexler
force-pushed
the
default-ignore
branch
from
bcb15e0
to
5c90b00
Compare
eps1lon
approved these changes
Jun 20, 2022
|
@all-contributors add @robin-drexler for docs |
|
I've put up a pull request to add @robin-drexler! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for testing-library/dom-testing-library#1138