feat/fix layout shifts #1392
feat/fix layout shifts #1392
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/pages/index.js
Outdated
| <Logo img_src={`${baseUrl}img/logo-large.png`} /> | ||
| <Logo | ||
| img_src={`${baseUrl}img/logo-large.png`} | ||
| img_width={128} |
There was a problem hiding this comment.
I prefer refactoring all of these to be the same as the other component (camelCased) instead of adding more props that don't follow normal conventions. Wdyt?
There was a problem hiding this comment.
i make pr via local file conventions. because 1 pr = 1 feature. if you want, i can add refactoring, too.
but it is not usual way. it is better to do new pr with refactoring (change to camel, and add linter to keep it in control)
There was a problem hiding this comment.
Since we're adding another prop here, I prefer seeing it done in this PR to follow the "boy scout rule". No need for a lint rule though :)
There was a problem hiding this comment.
fix only my new code, or small refactoring for all this part?
There was a problem hiding this comment.
"I prefer refactoring all of these" - ok
What you did:
Adds image dimensions to fix layout shifts
What happened:
When images don't have dimensions, layout can shift at slow connection