Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevate fire event page in prep for merge #502

Conversation

jacobparis
Copy link

As per conversation on #490 (and #485), the event firing utilities are largely universal and independent of the testing library family products they're imported into

This PR moves the existing Fire Event page from its nested folder in DOM Testing Library to the top level in preparation for it to be merged with the docs from User Event

@MatanBobi had begun working on #485 so I followed his model for the page structure to keep things consistent

This PR includes a 301 Redirect which, assuming I implemented it correctly, will cover all traffic going to the original Fire Event page and make this a non-breaking change

Screen Shot 2020-06-15 at 11 57 28 PM

I'm interested in any feedback or pushback with the goal of being able to migrate the docs from User Event to this repository in short order

@MatanBobi
Copy link
Member

Hi @jacobparis !
The work I did in this issue is still a WIP, I will issue a PR once done, but as you can see in the comments there, the structure will probably change and the Queries page won't be under "Getting Started"..

@jacobparis
Copy link
Author

Closing since the merge isn't happening now and when it does this will be horribly out of date

@nickmccurdy
Copy link
Member

nickmccurdy commented Jul 3, 2020

This still seems like a useful change to me, even without merging user-event. Perhaps we could reopen it and use similar formatting for user-event's page in #519.

@nickmccurdy
Copy link
Member

Seems like this was completed elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants