Replace jsdom-global with global-jsdom #760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use
jsdom-global
with React tests, you will see these warnings in the console:This package does not expose these functions. However, there is a modern fork,
global-jsdom
which offers the same API, but also exports all global DOM APIs properly.I propose changing the mention to the new package, as it is a more future-proof option.
cc @modosc who is maintaining global-jsdom