fix(click): click no longer blurs when focus changes during onClick event #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 97.14% 97.18% +0.04%
==========================================
Files 1 1
Lines 140 142 +2
Branches 35 33 -2
==========================================
+ Hits 136 138 +2
Misses 4 4
Continue to review full report at Codecov.
|
|
@all-contributors please add @jmcriffey for code and tests |
|
I've put up a pull request to add @jmcriffey! 🎉 |
|
🎉 This PR is included in version 8.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
hi @jmcriffey thanks for this. hope all is well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this issue while testing form components. It is common for a form to focus inputs that are invalid, and I was seeing strange behavior where I couldn't invalidate and focus the same input element twice. I did a bit of digging and see that events call blur after the click event is fired, so I believe we can fix this by checking to see if focus has already changed before calling blur.