fix(190): Add blur events in correct order #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blur occurs after mouse down, but before click. I can't find any official documentation, but here's a nice code pen: https://codepen.io/mudassir0909/pen/eIHqB
jsmapr1
commented
Feb 13, 2020
| fireEvent.mouseDown(element); | ||
| element.focus(); | ||
| const continueDefaultHandling = fireEvent.mouseDown(element); | ||
| if (continueDefaultHandling) { |
There was a problem hiding this comment.
Added to be consistent with single click
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
=========================================
+ Coverage 97.24% 98.6% +1.36%
=========================================
Files 1 1
Lines 145 143 -2
Branches 35 41 +6
=========================================
Hits 141 141
+ Misses 4 2 -2
Continue to review full report at Codecov.
|
jsmapr1
commented
Feb 13, 2020
| @@ -101,15 +105,6 @@ function fireChangeEvent(event) { | |||
| event.target.removeEventListener("blur", fireChangeEvent); | |||
| } | |||
|
|
|||
| function blurFocusedElement(element, focusedElement, wasAnotherElementFocused) { | |||
There was a problem hiding this comment.
Now that we focus before click, we don't need to blur elements at the end of the actions.
Merged
|
Merged in #218, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blur occurs after mouse down, but before click.
I can't find any official documentation, but here's a nice code pen (not using library):
https://codepen.io/mudassir0909/pen/eIHqB
This is important because an
onBlurevent in React happens beforeonClickand if it rerenders the element, theonClickevent never happens.This covered a case from a previous PR #208, so I remove the related code.
Let me know if you need anything else. 馃帀