upgrade testing environment #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph-fritsche
force-pushed
the
upgradeenv
branch
from
c6d9fb2
to
910fee5
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d036279:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
==========================================
- Coverage 99.46% 99.13% -0.34%
==========================================
Files 89 89
Lines 2067 2074 +7
Branches 701 698 -3
==========================================
Hits 2056 2056
- Misses 11 18 +7 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 14.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
These changes update the scripts to work with the rewritten Toolbox.
Interop and deep imports from
dom-testing-libraryhave been removed and the relevant code has been inlined.If the simplified error message for invalid arguments turns out to be insufficient, we should consider adding helpers for error messages on the official exports of DTL – e.g. on the config object.
I reverted the swap of the release action because
action-releaseis tested, requires less config for our workflow and defaults to Conventional Commits which allows to signal breaking changes in the commit summary (fix!:). If there are any issues with that action, please tell me and I'll try to fix it.How:
The
buildermodules have been removed from Toolbox.I decided to use
esbuildto bundle dependencies and environment setup.This conflicted with
baseUrl: /dev/nullin tsconfig which was a nice workaround to prevent IDEs from autocompleting to non-relative paths because the extended config setsbaseUrlto./src. If that turns out to be a problem again, we should probably just removeextendsfrom our base config.Checklist:
- [ ] Documentation