Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead link in CONTRIBUTING.md #1192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakeboone02
Copy link

What:

Updated link to KCD's PR course on Egghead.io.

Why:

Existing link leads to 404 page.

Checklist:

  • Ready to be merged

I'm wondering if it should be http://kcd.im/pull-request instead of the direct link.

Also, the same bad link appears on the testing-library/jest-dom contributing page, too:

https://github.com/testing-library/jest-dom/blob/main/CONTRIBUTING.md

I can submit a similar PR for that repo if necessary.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6792654:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant