New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ops.target to selectOptions #155
Add ops.target to selectOptions #155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 96.58% 96.63% +0.05%
==========================================
Files 1 1
Lines 117 119 +2
Branches 27 27
==========================================
+ Hits 113 115 +2
Misses 4 4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 96.58% 96.63% +0.05%
==========================================
Files 1 1
Lines 117 119 +2
Branches 27 27
==========================================
+ Hits 113 115 +2
Misses 4 4
Continue to review full report at Codecov.
|
I tried recreating the PR with |
I think this makes sense because:
I think its important to at least display a warning when trying to select an option that doesn't exist--as its very likely a bug. An alternative to that, would be userEvent.selectOptions(getByLabelText('Select'), [getByText('first option')]) That way you also get an error from Issue #203 has nice comments and is related to this PR. |
This is managed best in #297 so I'm going to close this. Thanks! |
In some cases, the
option.value
andoption.text
are not tightly coupled.Some developers want to hide the internal
option.value
and show nicely-formatted text.This PR will provide a way to specify how the options should be extracted.