Fix typing into validated input types #317
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Temporarily sets the target element's type to
text
until thetype
function resolvesWhy:
The
type
implementation depends onsetSelectionRange
which raises an error for validated input types likeemail
,number
How:
Take a guess 馃槤
Checklist:
I did try replacing
type
with a getter property to log a warning along the lines of "hey, you're accessingtype
whiletype
ing and the result will be inaccurate", but it turns out that it's referenced by testing machinery so frequently as to be useless. Does this behavior need to be documented anywhere?