Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add message if type/paste function is called with an invalid element #375

Merged
merged 6 commits into from Jun 21, 2020
Merged

fix: add message if type/paste function is called with an invalid element #375

merged 6 commits into from Jun 21, 2020

Commits on Jun 21, 2020

  1. test: add failing test

    @marcosvega91
    marcosvega91 committed Jun 21, 2020
    Copy the full SHA
    92c470c View commit details
    Browse the repository at this point in the history

  2. fix: add an explicit error on type function 

    If the user tries to call type function with an invalid element, an explicit error will be thrown.
This error should be better then 'TypeError: Cannot read property 'length' of undefined'
    @marcosvega91
    marcosvega91 committed Jun 21, 2020
    Copy the full SHA
    b9f3662 View commit details
    Browse the repository at this point in the history

  3. refactor: replace error with typerror

    @marcosvega91
    marcosvega91 committed Jun 21, 2020
    Copy the full SHA
    948facd View commit details
    Browse the repository at this point in the history

  4. test: add fail test for paste

    @marcosvega91
    marcosvega91 committed Jun 21, 2020
    Copy the full SHA
    261d843 View commit details
    Browse the repository at this point in the history

  5. fix: throw TypeError for paste and type functions

    @marcosvega91
    marcosvega91 committed Jun 21, 2020
    Copy the full SHA
    d902c09 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into pr/add_message_invalid_type_element

    @marcosvega91
    marcosvega91 committed Jun 21, 2020
    Copy the full SHA
    a3e3249 View commit details
    Browse the repository at this point in the history