Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tab): remove tabIndex set and unset for jsdom #379

Merged
merged 1 commit into from Jun 22, 2020

Conversation

juanca
Copy link
Collaborator

@juanca juanca commented Jun 22, 2020

What: Remove tabIndex management for tab method

Why: These pieces of code are not needed anymore with the current version of jsdom.

How: Removed and re-ran test suite.

Checklist:

  • Documentation N/A
  • Tests
  • Typings N/A
  • Ready to be merged

This is a followup from #368

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #379 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #379   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          392       387    -5     
  Branches       113       111    -2     
=========================================
- Hits           392       387    -5     
Impacted Files Coverage Δ
src/tab.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a270040...93704d5. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This may be a breaking change for people not on the latest version of jsdom which is a bit unfortunate. But I don't think we need a breaking change for it.

@kentcdodds kentcdodds merged commit 09dc3a9 into testing-library:master Jun 22, 2020
@juanca juanca deleted the clean-up-tab branch June 22, 2020 02:44
@kentcdodds
Copy link
Member

🎉 This PR is included in version 12.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants