Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable testing-library/no-dom-import eslint rule #382

Merged

Conversation

ybentz
Copy link
Collaborator

@ybentz ybentz commented Jun 25, 2020

What:
This PR disables the testing-library/no-dom-import eslint rule for the project.

Why:

The project currently imports directly from @testing-library/dom which causes the linter to throw and fail the pre-commit hook which makes it impossible to commit without bypassing the commit hook. This was @kentcdodds's suggested solution here.

How:

Updated package.json to turn this specific rule off.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Typings N/A
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #382 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #382   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          387       387           
  Branches       111       111           
=========================================
  Hits           387       387           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6acbdb4...4a2662d. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍👍

@kentcdodds kentcdodds merged commit 75bab48 into testing-library:master Jun 25, 2020
@kentcdodds
Copy link
Member

🎉 This PR is included in version 12.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants