fix: button trigger space #409
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -715,3 +715,48 @@ test('should give error if we are trying to call type on an invalid element', as | |
| `"the current element is of type BODY and doesn't have a valid value"`, | ||
| ) | ||
| }) | ||
|
|
||
| test('typing on button should not alter its value', () => { | ||
| const {element} = setup('<button value="foo" />') | ||
| userEvent.type(element, 'bar') | ||
| expect(element).toHaveValue('foo') | ||
| }) | ||
|
|
||
| test('typing on input type button should not alter its value', () => { | ||
| const {element} = setup('<input type="button" value="foo" />') | ||
| userEvent.type(element, 'bar') | ||
| expect(element).toHaveValue('foo') | ||
| }) | ||
|
|
||
| test('typing on input type color should not alter its value', () => { | ||
| const {element} = setup('<input type="color" value="#ffffff" />') | ||
| userEvent.type(element, 'bar') | ||
| expect(element).toHaveValue('#ffffff') | ||
| }) | ||
|
|
||
| test('typing on input type image should not alter its value', () => { | ||
| const {element} = setup('<input type="image" value="foo" />') | ||
| userEvent.type(element, 'bar') | ||
| expect(element).toHaveValue('foo') | ||
| }) | ||
|
|
||
| test('typing on input type reset should not alter its value', () => { | ||
| const {element} = setup('<input type="reset" value="foo" />') | ||
| userEvent.type(element, 'bar') | ||
| expect(element).toHaveValue('foo') | ||
| }) | ||
|
|
||
| test('typing on input type submit should not alter its value', () => { | ||
| const {element} = setup('<input type="submit" value="foo" />') | ||
| userEvent.type(element, 'bar') | ||
| expect(element).toHaveValue('foo') | ||
| }) | ||
|
|
||
| test('typing on input type file should not trigger input event', () => { | ||
| const inputHandler = jest.fn() | ||
| const {element} = setup('<input type="file" />', { | ||
| eventHandlers: {input: inputHandler}, | ||
| }) | ||
| userEvent.type(element, 'bar') | ||
| expect(inputHandler).toHaveBeenCalledTimes(0) | ||
| }) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,12 @@ | ||
| import {getActiveElement, isFocusable, eventWrapper} from './utils' | ||
|
|
||
| function blur(element) { | ||
| if (!isFocusable(element)) return | ||
|
|
||
| const wasActive = getActiveElement(element.ownerDocument) === element | ||
| if (!wasActive) return | ||
|
|
||
| eventWrapper(() => element.blur()) | ||
| } | ||
|
|
||
| export {blur} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,12 @@ | ||
| import {getActiveElement, isFocusable, eventWrapper} from './utils' | ||
|
|
||
| function focus(element) { | ||
| if (!isFocusable(element)) return | ||
|
|
||
| const isAlreadyActive = getActiveElement(element.ownerDocument) === element | ||
| if (isAlreadyActive) return | ||
|
|
||
| eventWrapper(() => element.focus()) | ||
| } | ||
|
|
||
| export {focus} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking this is probably a special case where simulating mousing over and clicking wouldn't make sense right? Because anyone trying to do:
userEvent.type(button, '{space}')is probably not wanting to fire two click events... Hmmm... Should we make this a special case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asking myself the same question. For the sake of consistency I decided it should behave the same way it does with other elements.
Maybe we could add a section about this to the documentation? So it is clear that the most popular way to test keyboard events on a button would be:
Another idea would be to use element.focus() instead of userEvent.click(element) as a default for
type.The benefit would be, that it is less "magic" and we could get rid of
skipClickaltogether.Also the
.focus()would just fire additional events, if the element doesn't have focus already. So it would just be a minimal safety net.For tests that require a
clickbeforehand, it would still be easy to do that: