Move types from DefinitelyTyped to this repository #165
Conversation
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| store: Store<any>, | ||
| router: Router, | ||
| ) => Partial<ThisTypedMountOptions<V>> | void |
There was a problem hiding this comment.
This line productes the following warning with latest config:
void is only valid as a return type or generic type variable
@typescript-eslint/no-invalid-void-type
not entirely sure I should be worried about this?
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 90 90
Branches 28 28
=========================================
Hits 90 90 Continue to review full report at Codecov.
|
| @@ -1,4 +1,7 @@ | |||
| module.exports = { | |||
| parserOptions: { | |||
| parser: '@typescript-eslint/parser', | |||
There was a problem hiding this comment.
Support for this is now built-in to the latest version of kcd-scripts (actually, eslint-config-kentcdodds, but that's what kcd-scripts uses).
There was a problem hiding this comment.
That's what I assumed when I checked the changelogs, but sadly enough eslint-plugin-vue requires us to use parserOptions.parser option instead of parser, because the latest needs to be used internally to parse Vue files.
SFC are cool but come with their own headaches 馃槄
|
馃帀 This PR is included in version 5.3.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
|
馃帀 This PR is included in version 6.6.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Following the steps of DTL, RTL, and CTL, this PR brings types home.
Any feedback by TS pro's is really appreciated 馃檶 @testing-library/core-maintainers