fix: avoid vite sideEffects bug

Use `import` instead of <script> Ref vitejs/vite#10735
textlint-rule · Feb 10, 2023 · 746be5b · 746be5b
1 parent 1b4308a
commit 746be5b
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 19 deletions.
diff --git a/public/index.html b/public/index.html
@@ -4,7 +4,13 @@
     <meta charset="UTF-8">
     <title>sentence-splitter</title>
     <link href="./index.css" rel="stylesheet">
-    <script src="./index.ts" type="module"></script>
+    <script type="module">
+        // Avoid Vite sideEffects bug
+        // https://github.com/vitejs/vite/issues/10735
+        import { run } from "./index.ts";
+
+        run();
+    </script>
 </head>
 <body>
 <main class="main">

diff --git a/public/index.ts b/public/index.ts
@@ -1,23 +1,25 @@
 import { split } from "../src/sentence-splitter.js";
 
-const textElement = document.querySelector("#text") as HTMLTextAreaElement;
-const jsonElement = document.querySelector("#json") as HTMLTextAreaElement;
+export const run = () => {
+    const textElement = document.querySelector("#text") as HTMLTextAreaElement;
+    const jsonElement = document.querySelector("#json") as HTMLTextAreaElement;
 
-const onUpdate = (text: string) => {
-    try {
-        const json = split(text);
-        jsonElement.textContent = JSON.stringify(json, null, 4);
-        location.hash = encodeURIComponent(text);
-    } catch {}
-};
+    const onUpdate = (text: string) => {
+        try {
+            const json = split(text);
+            jsonElement.textContent = JSON.stringify(json, null, 4);
+            location.hash = encodeURIComponent(text);
+        } catch {}
+    };
 
-textElement?.addEventListener("input", () => {
-    onUpdate(textElement.value);
-});
+    textElement?.addEventListener("input", () => {
+        onUpdate(textElement.value);
+    });
 
-const textFromURL = location.hash;
-if (textFromURL.length > 0) {
-    const decodedText = decodeURIComponent(textFromURL);
-    textElement.value = decodedText;
-    onUpdate(decodedText);
-}
+    const textFromURL = location.hash;
+    if (textFromURL.length > 0) {
+        const decodedText = decodeURIComponent(textFromURL);
+        textElement.value = decodedText;
+        onUpdate(decodedText);
+    }
+};