-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilang #39
Multilang #39
Conversation
✅ Deploy Preview for sentence-splitter ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
package.json
Outdated
"exports": { | ||
".": { | ||
"import": { | ||
"types": "./module/sentence-splitter.d.ts", | ||
"default": "./module/sentence-splitter.js" | ||
}, | ||
"require": { | ||
"types": "./lib/sentence-splitter.d.ts", | ||
"default": "./lib/sentence-splitter.js" | ||
}, | ||
"default": "./lib/sentence-splitter.js" | ||
}, | ||
"./package.json": "./package.json" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What problems have you encountered with exports
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've managed to make it work. Just in my application's tsconfig.json I had to change moduleResolution from node
to bundler
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I see.
TypeScript requires nodenext
/node16
or bundler
as moduleResolution
for resolving exports
fields.
node
does not resolve exports
fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this PR is a change to allow AbbrMarkerOptions to be passed from the outside.
This change itself is good because it was planned.
I had one question and I commented on it.
#40