-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: drop Node.js 16 #1337
CI: drop Node.js 16 #1337
Conversation
This is caused by ts-node issue. |
.github/workflows/ci.yml
Outdated
@@ -9,7 +9,7 @@ jobs: | |||
matrix: | |||
os: [ubuntu-latest, windows-latest] | |||
# https://github.com/TypeStrong/ts-node/issues/2094 | |||
node: [ 16, 18.18.2 ] | |||
node: [ 18.18.2, 20 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18.19.0 and 20.x change --import
behavior.
It breaks tests.
We need to find a solution to this problem.
- use tsimp - some behavior is different with ts-node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mocha --import ts-node/esm does not handle import("./file.ts").
close #1336
Changes
import
instead ofloader
loader
cause ERR_UNKNOWN_FILE_EXTENSION error.js
instead of.ts
in some dynamic importing test--rules-dir
test need to import js file, but--import
can not transpile it.