BREAKING CHANGE: Change textlint-scirpts output target #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tible with Node.js 18 or later. It aims to reduce output code size
azu
commented
Feb 1, 2024
| function _default(context, options = {}) { | ||
| const { Syntax, RuleError, report, getSource } = context; | ||
| return { | ||
| async [Syntax.Document](node) { |
There was a problem hiding this comment.
The output remain native async await.
azu
commented
Feb 1, 2024
Comment on lines
9
to
13
| { | ||
| // For async/await support | ||
| // https://babeljs.io/docs/en/babel-preset-env#targetsesmodules | ||
| targets: { | ||
| esmodules: true | ||
| // Same version with textlint's supported Node.js version | ||
| node: "18.14.0" | ||
| }, |
There was a problem hiding this comment.
This is main change.
- ES2015 → ES2022
azu
commented
Feb 1, 2024
Comment on lines
+36
to
+38
| "engines": { | ||
| "node": ">=18.19.0" | ||
| }, |
There was a problem hiding this comment.
textlint-scriptsr requires latest Node.js 18.x.
In the future, we might implement the hook processing using the node:module register API, so I'm choosing the latest version, 18.19.0.
azu
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
textlint-script buildsoutput ES2022-compatible code.Previously, the output is ES2015-compatible code.
Modern browsers and Node.js LTS support ES2022.
Details
In this PR, the target code for textlint-script output is changed to Node.js v18.14.0 or later.
This will reduce the cost of output code size and runtime.
The default target is the minimum version of node.js supported by the text link.
In other words, it is Node.js v18.14.0>=.
Runtime(browser/node.js) require to support ES2022+.
close #1344
refs #1200