Open favorites at startup and re-activation

[estum]

Added a checkbox in the files preference pane which enables showing the
favorites chooser at startup and re-activation with no open documents.
This option is mutually exclusive with «Create one at startup» and
«Create one at re-activated» settings.

[sorbits]

Thanks, two comments:

1. I think the setting should not have a disable-prefix. The reason we use that prefix for the other settings is because we disable standard behavior. For this feature, the default is to have the behavior disabled.
2. I don’t think using applicationWillBecomeActive: gives us proper semantics. We only want the favorites dialog when the user clicks the TextMate icon (and there are no open documents), at least that would be consistent with how auto-creation of untitled documents work. For this I think we can place the check in applicationOpenUntitledFile: and update the logic in applicationShouldHandleReopen:hasVisibleWindows: to return YES when the feature is enabled.

[estum]

@sorbits done, but I am not sure about correctness of estum/textmate@817978d which references to the second point of your comment. Please, check it (but, still, I'd skip the last commit).

[sorbits]

I think the behavior is as expected, i.e. I get the favorites (only) when opening TextMate (and there are no windows to be restored) or when clicking the application icon.

I have merged the code changes you did as 71a2c2d — I made a few formatting changes and also changed the preferences key to showFavoritesInsteadOfUntitled (since I think that is a more apt description).

I did not merge the GUI changes because I think the way it worked was confusing. I would however prefer to get the setting exposed in preferences so I’m leaving your pull request open and plan to revisit it later.

I apologize for the slow response time.

[sorbits]

What do you think about changing the behavior so that the favorites instead (optionally) open once the last document window is closed?

It seems to me we want to pick from favorites (recent projects) either when launching TextMate and there is no session to restore, or when closing our (last) project, not really on re-activation.

[eyelidlessness]

The on-close behavior is usually unexpected for Mac apps. The typical behavior for a prompt like this is:

• When opening app with nothing to restore
• When nothing is open, clicking the Dock icon
• (Less known, but has the same behavior as clicking the Dock icon) When nothing is open, highlighting the app in command-tab, then holding option before releasing command

I've only ever seen behavior upon closing the last window in apps ported from Windows.

[sorbits]

@Uvaldoxx If somebody has signed up for a GitHub account with your email address and then subscribed to notifications then you need to contact GitHub staff to get the issue resolved. They are unlikely to see the comments you post here.

You can also perform a password reset for the account then login and disable notifications / change email / delete account.

The account seems to be unused, so probably just do the latter.

Disclaimer: I am not with GitHub staff / support, and I do not control which emails are sent to you from GitHub.