Homebrew on Apple Silicon / XCode 13.2 support #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgavris
commented
Dec 26, 2021
| @@ -334,16 +334,17 @@ bool write_data () const | |||
| { | |||
| reactivate_callback_t () : _shared_count(std::make_shared<size_t>(0)) | |||
| { | |||
| _terminal = std::make_shared<NSRunningApplication*>([NSWorkspace.sharedWorkspace frontmostApplication]); | |||
There was a problem hiding this comment.
In file included from Applications/TextMate/src/RMateServer.mm:1:
In file included from /Users/jgavris/code/textmate/Shared/PCH/prelude.mm:6:
In file included from /Users/jgavris/code/textmate/Shared/PCH/prelude.cc:9:
In file included from /Applications/Xcode-v13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/algorithm:653:
/Applications/Xcode-v13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/memory:2684:27: error: cast of a non-Objective-C pointer type 'typename _CompressedPair::_Base2 *' (aka '__compressed_pair_elem<NSRunningApplication *__strong, 1> *') to 'NSRunningApplication *__strong *' is disallowed with ARC
_Tp *__elem = reinterpret_cast<_Tp*>(__second);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode-v13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/memory:2635:53: note: in instantiation of member function 'std::__shared_ptr_emplace<NSRunningApplication *, std::allocator<NSRunningApplication *>>::_Storage::__get_elem' requested here
_Tp* __get_elem() _NOEXCEPT { return __storage_.__get_elem(); }
^
/Applications/Xcode-v13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/memory:3387:76: note: in instantiation of member function 'std::__shared_ptr_emplace<NSRunningApplication *, std::allocator<NSRunningApplication *>>::__get_elem' requested here
return shared_ptr<_Tp>::__create_with_control_block((*__control_block).__get_elem(), _VSTD::addressof(*__control_block));
^
/Applications/Xcode-v13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/memory:3394:19: note: in instantiation of function template specialization 'std::allocate_shared<NSRunningApplication *, std::allocator<NSRunningApplication *>, NSRunningApplication *, void>' requested here
return _VSTD::allocate_shared<_Tp>(allocator<_Tp>(), _VSTD::forward<_Args>(__args)...);
^
Applications/TextMate/src/RMateServer.mm:337:21: note: in instantiation of function template specialization 'std::make_shared<NSRunningApplication *, NSRunningApplication *, void>' requested here
_terminal = std::make_shared<NSRunningApplication*>([NSWorkspace.sharedWorkspace frontmostApplication]);
^
1 error generated.
KittyMac
added a commit
to KittyMac/textmate
that referenced
this pull request
Jul 7, 2022
on M1 and XCode 13.2
|
@sorbits would it be possible to give this a look? Would really appreciate being able to build TextMate on my Mac again. 🙂 |
|
@sorbits do you expect to do something with this? |
|
It seems that this repo is dead. Last commit is from 2021-10-12… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew --prefixfor the new/opt/homebrewhome on Apple Silicon.shared_ptrcast warning inRMateServer.vforkis now deprecated (has same behavior asforkon macOS 12 and above, and will be removed eventually).