Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of -chdir with an absolute path #355

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix use of -chdir with an absolute path #355

wants to merge 3 commits into from

Conversation

OJFord
Copy link
Contributor

@OJFord OJFord commented Jul 27, 2022

Fixes #354.

@Zordrak Zordrak force-pushed the fix-354 branch 2 times, most recently from 129ce8f to edde4d2 Compare October 1, 2022 16:10
Zordrak
Zordrak requested changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@Zordrak Zordrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail because realpath is not available in the default toolset on macos.

@OJFord OJFord force-pushed the fix-354 branch 6 times, most recently from c585108 to 9cb216c Compare November 5, 2022 00:09
@OJFord OJFord mentioned this pull request Nov 5, 2022
Closed
@OJFord OJFord requested a review from Zordrak November 5, 2022 00:21
@OJFord
Copy link
Contributor Author

OJFord commented Mar 18, 2023

Tests fail because realpath is not available in the default toolset on macos.

Hi @Zordrak, I believe I fixed that issue if you have time for another look. Cheers.

@OJFord
Copy link
Contributor Author

OJFord commented Feb 10, 2024

Anything else still needed here @Zordrak?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zordrak Zordrak Awaiting requested review from Zordrak

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-chdir doesn't work with an absolute path
2 participants
@OJFord @Zordrak