Le video Take 2 #22
Open
Le video Take 2 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like le_pixels should be more about actual pixel access and manipulation and the image loading part could be its own module that generates le_pixels. On the other hand it is pretty nice to just pass in an image path and have it translate automatically |
|
Le video should be a separate addon. Still need an api to modify pixel resources though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation uses libvlc. Mainly because it is easy to use, cross platform and plays pretty much every video format. It might also be useful to implement le_audio sometime
The interesting part though are the changes to resource manager and pixels. Pixels can now be locked on demand before accessing the data, while the resource manager supports adding and updating raw le_pixels.