Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make assets #3906

Merged
merged 1 commit into from Mar 11, 2021
Merged

Fix make assets #3906

merged 1 commit into from Mar 11, 2021

Conversation

saswatamcode
Copy link
Member

Pertaining issues

#3892

Changes

Fixes make assets command, which failed earlier due to a react-scripts issue. Currently pkg/ui/react-app uses react-scripts version 3.4.4. This leads to a typescript version issue which causes the command to fail during building the react app with the following error,

./src/utils/index.ts
  Line 0:  Parsing error: Cannot read property 'map' of undefined


error Command failed with exit code 1.

Downgrading to typescript version 3.9.9 fixes this issue. Upgrading react-scripts is not feasible at the time due to the caveats mentioned here.

Verification

make assets now runs smoothly,

$ react-scripts build
Creating an optimized production build...
Compiled successfully.
.
.
.
The project was built assuming it is hosted at ./.
You can control this with the homepage field in your package.json.

The build folder is ready to be deployed.

Find out more about deployment here:

  bit.ly/CRA-deploy

✨  Done in 138.33s.
>> deleting asset file
>> writing assets
>> formatting go code
>> formatting shell scripts

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
@bwplotka bwplotka requested a review from onprem March 10, 2021 18:59
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, let's see what @prmsrswt says 🤗

@onprem onprem linked an issue Mar 10, 2021 that may be closed by this pull request
Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@onprem onprem merged commit 45163f2 into thanos-io:main Mar 11, 2021
andrejbranch pushed a commit to andrejbranch/thanos that referenced this pull request Mar 11, 2021
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make assets ends with error
3 participants