Skip to content

Commit

Permalink
Better prettier plugin for sorting imports (#228)
Browse files Browse the repository at this point in the history
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
enisdenjo and github-actions[bot] committed May 22, 2023
1 parent bfd1ed8 commit e899b0c
Show file tree
Hide file tree
Showing 5 changed files with 51 additions and 137 deletions.
6 changes: 6 additions & 0 deletions .changeset/@theguild_prettier-config-228-dependencies.md
@@ -0,0 +1,6 @@
---
"@theguild/prettier-config": patch
---
dependencies updates:
- Added dependency [`@ianvs/prettier-plugin-sort-imports@4.0.0-alpha.3` ↗︎](https://www.npmjs.com/package/@ianvs/prettier-plugin-sort-imports/v/4.0.0) (to `dependencies`)
- Removed dependency [`@trivago/prettier-plugin-sort-imports@^4.1.1` ↗︎](https://www.npmjs.com/package/@trivago/prettier-plugin-sort-imports/v/4.1.1) (from `dependencies`)
5 changes: 5 additions & 0 deletions .changeset/three-bugs-sleep.md
@@ -0,0 +1,5 @@
---
'@theguild/prettier-config': minor
---

Better prettier plugin for sorting imports
13 changes: 1 addition & 12 deletions packages/prettier-config/index.cjs
@@ -1,5 +1,3 @@
const { builtinModules } = require('node:module');

module.exports = {
trailingComma: 'all', // default to `all` in v3
printWidth: 100,
Expand Down Expand Up @@ -27,15 +25,9 @@ module.exports = {
// for sort fields in package.json
require('prettier-plugin-pkg'),
// for sorting imports
require('@trivago/prettier-plugin-sort-imports'),
require('@ianvs/prettier-plugin-sort-imports'),
],
importOrder: [
// TODO: Sort side effects on the top
// See more: https://github.com/trivago/prettier-plugin-sort-imports/issues/110
// Node.js builtins
`^(node:)?(${builtinModules
.filter(mod => !mod.startsWith('_') && !mod.includes('/'))
.join('|')})(/.*|$)`,
// React and Next.
'^react(-dom)?$',
'^next(/.*|$)',
Expand All @@ -48,8 +40,5 @@ module.exports = {
// Other files with extensions.
'^.+\\.(graphql|css|png|svg|jpe?g|webp|avif|wasm|mp4|webm)$',
],
importOrderSeparation: false, // import order groups won't be separated by a new line
importOrderSortSpecifiers: true, // sorts the import specifiers alphabetically
importOrderCaseInsensitive: true, // case-insensitive sorting
importOrderParserPlugins: ['typescript', 'jsx', 'decorators-legacy'],
};
2 changes: 1 addition & 1 deletion packages/prettier-config/package.json
Expand Up @@ -21,7 +21,7 @@
"prettier": "^2"
},
"dependencies": {
"@trivago/prettier-plugin-sort-imports": "^4.1.1",
"@ianvs/prettier-plugin-sort-imports": "4.0.0-alpha.3",
"prettier-plugin-pkg": "^0.17.1",
"prettier-plugin-sh": "^0.12.8"
},
Expand Down

0 comments on commit e899b0c

Please sign in to comment.