Fixes #36809 - Do not clobber answers provided on the command line wi… #891
Conversation
…th --certs-regenerate
|
|
||
| kafo.config.store(answers) | ||
| kafo.send(:store_params) |
There was a problem hiding this comment.
I agree this is a bit ugly, calling into a private method. My goal here is to patch the problem first with a fix that can be cherry picked cleanly backward. The alternative is to add methods to kafo and then release a patch release and also a patch to the installer for older releases.
|
This is intended to be a patch that fixes the issue, and I think what needs to follow is a real fix to the way we regenerate certificates which is now possible that we have gotten rid of the RPM part. |
|
Some notes: it was introduced in e28a519 and we shouldn't store I'm now debating options, but can't think of any right now. I'll get back to this. |
|
[test foreman-installer] |
|
@ekohl This is still a pretty ugly problem that it can cause, do you have any additional thoughts or review? |
…th --certs-regenerate
Problem:
The installer will see and run as if the
statevalue was changed to Texas, regenerating certificates. However, becausekafo.config.app.answersreturns the answers file and not the compiled params, what gets written back to the answers file is the original answers at runtime. Thus the answers file now have the previous value (e.g. North Carolina) and the next installer run will trigger a certificate update under the hood.