Refs #33974 - Update the db_pool value #937
Conversation
|
This also needs a katello migration -- use https://github.com/theforeman/foreman-installer/blob/develop/bin/create-migration and then copy the logic into the file it creates |
config/foreman.migrations/20240505103832_change_db_pool_size.rb
Outdated
Show resolved
Hide resolved
ShimShtein
force-pushed
the
add_db_pool_migration
branch
from
ea329d1
to
1a3e0cf
Compare
|
@ehelms added the same migration also to Katello. @evgeni: currently the code makes sure the db_pool size is at least the number we recommend. If the user has the number bigger - we won't change it. This duplicates the logic, but I think it's not that bad, especially since the migration is a one time thing. |
ShimShtein
force-pushed
the
add_db_pool_migration
branch
from
1a3e0cf
to
2870d7d
Compare
|
Updated the minimum to 5 |
|
[test foreman-installer] |
ShimShtein
force-pushed
the
add_db_pool_migration
branch
from
2870d7d
to
afd9a84
Compare
ShimShtein
force-pushed
the
add_db_pool_migration
branch
from
afd9a84
to
f5a94e8
Compare
ShimShtein
force-pushed
the
add_db_pool_migration
branch
2 times, most recently
from
44e3086
to
d1f2c4b
Compare
ehelms
changed the title
|
Tests are currently failing as we have dependency mismatch while installer modules are being released. |
|
That should be resolved. Please rebase |
The new value should be at least the number of puma threads + 4. More details: https://community.theforeman.org/t/rails-connection-pool-size-optimizations/36675
ShimShtein
force-pushed
the
add_db_pool_migration
branch
from
d1f2c4b
to
8fb4afd
Compare
|
@ekohl Rebased, the tests are green! |
|
I think @evgeni's concerns are addressed, but leaving it to him to press the green button. |
The new value should be at least the number of puma threads + 4.
More details: https://community.theforeman.org/t/rails-connection-pool-size-optimizations/36675