Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #26850 - set ansible_become_method per REX effective method #271

Merged
merged 1 commit into from Aug 8, 2019

Conversation

snagoor
Copy link
Contributor

@snagoor snagoor commented May 22, 2019

Set ansible privilege escalation method ansible_become_method per REX remote_execution_effective_user_method setting.

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for b1affe0 exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@snagoor snagoor changed the title Fixes #26850 - set ansible_become_method per REX effective method set… Fixes #26850 - set ansible_become_method per REX effective method May 22, 2019
@ares
Copy link
Member

ares commented Jun 11, 2019

[test foreman_ansible] should be fixed by #274

/usr/local/rvm/gems/ruby-2.6.3@foreman_ansible-pull-request-3/gems/factory_bot-5.0.2/lib/factory_bot/definition_proxy.rb:97:in `method_missing': undefined method 'template' in 'job_template' factory (NoMethodError)

@ares
Copy link
Member

ares commented Jul 23, 2019

this now fails due to rubocop, we'll fix it elsewhere, tests were green

322 runs, 663 assertions, 0 failures, 0 errors, 0 skips
144 runs, 327 assertions, 0 failures, 0 errors, 0 skips

so we can proceed with the review

Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ares
Copy link
Member

ares commented Aug 8, 2019

Failures are due to rubocop issue, merging. Thanks @snagoor and @ezr-ondrej

@ares ares merged commit cebfe4d into theforeman:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants