Decouple from Guzzle by using HTTPlug interfaces. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
hey @mekras, thanks for the PR. It might take some time for this to merged since this is a big change and so it will most likely be released in Version 3. I also want to make v3 use a lot of PHP 7 new features, I'm currently working on these refactors. |
|
@jorgeborges how is v3 progressing? Can we create a milestone for that and write tasks (issues) for the bits that would need refactoring? Maybe the community can help with this. |
qdequippe
reviewed
Oct 19, 2019
| @@ -11,9 +11,13 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.5", | |||
| "guzzlehttp/guzzle": "^6.0" | |||
There was a problem hiding this comment.
What about require also psr/http-client-implementation?
|
@jorgeborges did you plan a v3? I will be happy to contribute :) |
|
Implementing this PR would be perfect to remove guzzle dependency, I am having to abandon the use of this project due to this. |
|
why not psr-18? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPlug allows to write reusable libraries and applications that need an HTTP client without binding to a specific implementation. More about HTTPlug.